You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 12, 2021. It is now read-only.
Hi @charsyam, thanks for your patch.
Since I'm not familiar with RESTful API, I would like to ask a question.
Given a create database statement, the database_name is a variable defined by users.
For such variables, IMHO, passing database_name as a parameter looks more intuitive.
Are there any conventions in designing RESTful API?
@jihoonson Hi, jihoon. Thanks for your review :)
You're right. It is not real REST style.
but in my case, POST /databases has only one parameter as its name.
so I think POST /databases/{database-name} is more simple and understable. :)
But, It is not REST API.
so. I don't matter if you close this issue :)
Thanks for your comment.
In terms of the consistency of APIs, I think that create database API should have the equivalent form of create table API.
So, passing database_name as a parameter looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in Rest API
POST /databases/{database_name} is more understandable
comparing to POST /databases with database_name parameter